Skip to content

feat(cli): add support for JetBrains editors during the editor setup question - #2204

Open
KTrain5169 wants to merge 15 commits into
voidzero-dev:mainfrom
KTrain5169:jetbrains-editors
Open

feat(cli): add support for JetBrains editors during the editor setup question#2204
KTrain5169 wants to merge 15 commits into
voidzero-dev:mainfrom
KTrain5169:jetbrains-editors

Conversation

@KTrain5169

@KTrain5169 KTrain5169 commented Jul 20, 2026

Copy link
Copy Markdown

Closes #1987

This PR adds JetBrains editors as an option during the editor setup step.
As of writing this, the PR simply writes the Oxc plugin ID to .idea/externalDependencies.xml. I plan to go through editor settings (for WebStorm at least) to evaluate which keys are relevant to Oxc and should be set, hence the draft status.

Up for debate

  • Should the option be named "JetBrains (IntelliJ, WebStorm, etc)" or is just "WebStorm"/"IntelliJ" enough in the menu?
  • The CLI also writes intellij.vitejs to the externalDependencies file. Should this remain in the PR? I'm not confident it supports Vite+ properly. Removed pending better integration from JetBrains' side
  • Currently the system is a bit hacky given that all other editors read JSON instead of XML. If this becomes a consistent problem (as in, editors start having their own different file formats), then it may be better to rewrite the system a bit so that the file type is automatically detected from the file extension, and all that needs to be supplied to the entry in EDITORS is a key noting the name of the file, and an object describing the shape of the file, with the writing stage formatting it to the expected file type inferred from the file extension before putting it in the file.
  • It should not 100% work with merging with existing externalDependencies.xml files yet (already having some changes lined up to get this properly working) turns out merging the XML configs is extremely complicated!
  • Should the CLI also try and set up the JS runtime & package manager options? package manager is set to pnpm by default and it should point to the Vite+ Node shim)

@netlify

netlify Bot commented Jul 20, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 4e06aac
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a7320f1c493ea0008ac7b2b

@KTrain5169 KTrain5169 changed the title Add support for JetBrains editors during the editor setup question feat(cli): add support for JetBrains editors during the editor setup question Jul 26, 2026
@KTrain5169
KTrain5169 marked this pull request as ready for review August 5, 2026 06:54
@fengmk2 fengmk2 self-assigned this Aug 5, 2026
@fengmk2

fengmk2 commented Aug 5, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fdfb830ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/utils/editor.ts
Comment thread packages/cli/src/utils/editor.ts Outdated
Comment thread packages/cli/src/utils/editor.ts Outdated
Comment thread packages/cli/src/utils/editor.ts Outdated
Comment thread packages/cli/src/utils/editor.ts Outdated
Comment on lines +207 to +208
id: 'jetbrains',
label: 'JetBrains (IntelliJ, WebStorm, etc)',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Accept common JetBrains IDE names

The new option is presented as covering IntelliJ/WebStorm, but CLI resolution still only accepts the literal id jetbrains or the full display label. Users who pass --editor webstorm or --editor intellij get no editor config and no error, so add aliases for the named JetBrains IDEs or reject unknown editor values explicitly.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about how to deal with this, I assume we just leave this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting up IntelliJ at the editor setup menu

2 participants