feat(cli): add support for JetBrains editors during the editor setup question - #2204
feat(cli): add support for JetBrains editors during the editor setup question#2204KTrain5169 wants to merge 15 commits into
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
This reverts commit 07bdba1.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fdfb830ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: 'jetbrains', | ||
| label: 'JetBrains (IntelliJ, WebStorm, etc)', |
There was a problem hiding this comment.
Accept common JetBrains IDE names
The new option is presented as covering IntelliJ/WebStorm, but CLI resolution still only accepts the literal id jetbrains or the full display label. Users who pass --editor webstorm or --editor intellij get no editor config and no error, so add aliases for the named JetBrains IDEs or reject unknown editor values explicitly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not sure about how to deal with this, I assume we just leave this right?
…normalize nodejs_interpreter_path
Closes #1987
This PR adds JetBrains editors as an option during the editor setup step.
As of writing this, the PR simply writes the Oxc plugin ID to
.idea/externalDependencies.xml. I plan to go through editor settings (for WebStorm at least) to evaluate which keys are relevant to Oxc and should be set, hence the draft status.Up for debate
The CLI also writesRemoved pending better integration from JetBrains' sideintellij.vitejsto theexternalDependenciesfile. Should this remain in the PR? I'm not confident it supports Vite+ properly.It should not 100% work with merging with existing externalDependencies.xml files yet (already having some changes lined up to get this properly working)turns out merging the XML configs is extremely complicated!Should the CLI also try and set up the JS runtime & package manager options?package manager is set to pnpm by default and it should point to the Vite+ Node shim)