docs-audit: surface map + snapshot bookkeeping (2026-08-05 drift-watch) - #482
Merged
Conversation
Map the Factory MCP OAuth discovery routes and GET /factory/{uid}/metrics as
internal, point the new CLI zero-state setting at the CLI configuration page,
and refresh the surface snapshot.
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Warp Agent <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hongyi-chen
marked this pull request as ready for review
August 5, 2026 19:23
hongyi-chen
enabled auto-merge (squash)
August 5, 2026 19:23
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR updates missing_docs bookkeeping by classifying newly triaged surfaces in feature_surface_map.md and refreshing surface_snapshot.json for the 2026-08-05 drift-watch baseline.
Concerns
- No blocking general, security, or spec-alignment concerns found in the attached diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
rachaelrenk
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bookkeeping for the 2026-08-05
missing_docsdrift-watch run: surface-map decisions for everything triaged in this run, plus a refreshed surface snapshot so the next run diffs against today's baseline. Both audit modes exited 0 with no skipped audits and no unaccounted surface items.Changes
.agents/skills/missing_docs/references/feature_surface_map.md
GET /.well-known/oauth-authorization-server→internalGET /.well-known/oauth-protected-resource/api/v1/mcp/factory→internalRFC 8414 / RFC 9728 OAuth discovery documents that MCP clients fetch automatically before authenticating against the hosted Factory MCP endpoint (
router/handlers/public_api/oauth2.go). They are registered only when the dogfood-onlyfactory_mcpflag is on (factory_mcp: falseinconfig/prod.yaml), are absent from warp-server's canonical public spec, and are machine-facing protocol metadata rather than a documentable API surface.GET /factory/{uid}/metrics→internalAdded to the existing Factory block. Factory is not publicly released, and the operation carries
x-internal: truein warp-server's canonical spec, so the publish filter strips it from the docs copy.appearance.zero_state.freeze_animation_when_unfocused→src/content/docs/cli/configuration.mdxWarp Agent CLI-only setting (
SettingSurfaces::TUI), documented on the CLI configuration page rather than the all-settings reference, matching the otherappearance.zero_stateknobs..agents/skills/missing_docs/references/surface_snapshot.json
--update-snapshot. New entries: the four API routes above plusPOST /api/v1/agent/runs/{runId}/scores, the Oz web app routeartifacts/:artifactUid, the server toolget_media_artifact_links, and the settingappearance.zero_state.freeze_animation_when_unfocused.Companion feature PRs from this run
/copy-debugging-idslash command (extended with the CLI reference and feedback guide).freeze_animation_when_unfocusedsetting.The surface-map entry for
freeze_animation_when_unfocusedpoints at a page that already exists onmain, so this PR is independently mergeable in any order.Deferred findings (nothing dropped)
OpenAPI spec drift — route through the
sync-openapi-specskill, not hand-written docs. Three released endpoints are in warp-server's canonical spec withoutx-internalbut missing fromdevelopers/agent-api-openapi.yaml:GET /agent/artifacts/{artifactUid}/downloadGET /agent/run-by-external-referencePOST /agent/runs/{runId}/scoresThe sync script's
--mode diffreports no unclassified (!) items, but a regenerated subset would also add research-preview Agent Memory schemas (AgentMemoryCreateConfig,AgentMemoryResponse,AgentMemoryUpdateConfig,AgentAutoMemoryCreateConfig,AgentAutoMemoryResponse,MemoryStoreAttachmentResponse), plus modifications to 18 existing schemas. Publishing memory configuration whileAIMemoriesis still research preview would contradict the skill's public/private guardrail, so this run stopped short of applying the sync. Recommended follow-up: decide whether those schemas should be excluded by the sync policy or markedx-internalin warp-server, then runsync-openapi-specas its own PR.POST /agent/runs/{runId}/scoresis also worth a second look — it exists for judge runs reporting Factory scorer verdicts, so it may warrantx-internalupstream.Terminology/staleness (30 remaining findings). Every match was inspected in context and confirmed correct as written: telemetry event tables in
privacy.mdx, the current "AI Command Search" feature name,agent-modeURL slugs and image filenames, the "AI credits" bucket name, and deliberate "Warp terminal" vs. Oz distinctions. Two genuine violations were fixed in #481. Broader wording enforcement remains with thestyle_lintskill.Weak coverage (81 findings,
--weak-coverage). Spot-checked and confirmed to be keyword-heuristic noise: for exampleGroupedTabs→terminal/windows/tabs.mdx(four "tab group" mentions),CloudRunners→platform/runners.mdx(37 "runner" mentions),NamedAgents→platform/agents.mdx(covers cloud agents throughout). No action taken.Clean categories. No findings for feature flags, CLI commands, map hygiene, stale doc references, unlisted sidebar pages, or changelog review.
Validation
audit_docs.py(coverage and--diff) exit 0,audits_skippedempty,unaccountedempty.npm run buildpasses;check_links.pyreports 0 broken links.Co-Authored-By: Oz oz-agent@warp.dev
Co-Authored-By: Warp Agent agent@warp.dev