Exclude triangle-referenced vertices from support-vertex eligibility - #213
Open
webdevred wants to merge 4 commits into
Open
Exclude triangle-referenced vertices from support-vertex eligibility#213webdevred wants to merge 4 commits into
webdevred wants to merge 4 commits into
Conversation
webdevred
force-pushed
the
triangles-excluded-from-support-vertices
branch
from
August 8, 2026 16:44
763ed48 to
c9d3847
Compare
getTriangleVertexNames failed the whole transform as soon as any row in "triangles" wasn't a bare [String, String, String] triple. Per-triangle metadata objects (groundModel, dragCoef, etc.) are normal in real jbeam files, 11 of 11 sampled example files have them, so this broke --transform on almost anything with a triangles section (e.g. van_frame.jbeam). Skip comment and object rows the same way BeamExtraction.possiblyBeam already does for "beams", instead of failing the section outright. Fixture lives in examples/regression_jbeam/, not examples/jbeam/, so it stays out of jbeam-edit-dump-ast's scan (which only reads examples/jbeam/ and would exitFailure on any file that fails to transform) and out of the curated example set the jbeam maintainer keeps.
webdevred
force-pushed
the
triangles-excluded-from-support-vertices
branch
from
August 9, 2026 19:49
c9d3847 to
85da82b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.