fix(validator): log admin API internal errors - #2517
Open
sergerad wants to merge 1 commit into
Open
Conversation
sergerad
force-pushed
the
sergerad-validator-admin-api
branch
from
August 31, 2026 01:18
ce18d90 to
ea5a42d
Compare
sergerad
changed the base branch from
next
to
sergerad-validator-share-hardening
August 31, 2026 01:19
This was referenced Aug 31, 2026
sergerad
changed the title
sergerad
force-pushed
the
sergerad-validator-admin-api
branch
from
August 31, 2026 02:13
ea5a42d to
2765c08
Compare
sergerad
force-pushed
the
sergerad-validator-admin-api
branch
from
August 31, 2026 02:28
2765c08 to
a94a2d2
Compare
sergerad
marked this pull request as ready for review
August 31, 2026 02:35
sergerad
force-pushed
the
sergerad-validator-admin-api
branch
from
August 31, 2026 02:50
a94a2d2 to
8cf624d
Compare
Internal failures in the admin handlers were mapped to generic 500 messages with the underlying error discarded entirely: these are plain axum handlers, not covered by the miden_instrument(err) fault reporting the gRPC services get, so a database failure left no trace anywhere. Make ApiError::internal take the cause and log it with its source chain via ErrorReport::as_report, matching the ntx-builder precedent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sergerad
force-pushed
the
sergerad-validator-admin-api
branch
from
August 31, 2026 02:59
8cf624d to
33ab15c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 4 of a 4-PR stack formalizing the validator admin API (#2455). Closes #2455.
Internal failures in the admin handlers were mapped to generic 500 messages with the underlying error discarded entirely. These are plain axum handlers — not covered by the
miden_instrument(err)fault reporting the gRPC services get — so a database failure left no trace anywhere: no log, no trace, no detail in the response.ApiError::internalnow requires the cause and logs it with its full source chain viaErrorReport::as_reportbefore returning the generic message, matching the ntx-builder precedent (log the detail, return a generic message). Making the cause a required argument means it cannot be discarded by accident at future call sites.Stack: #2531 → #2532 → #2533 → #2517
Changelog