feat(validator): paginated admin transaction listing - #2532
Open
sergerad wants to merge 1 commit into
Open
Conversation
This was referenced Aug 31, 2026
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:13
d32b468 to
e4c2962
Compare
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:28
e4c2962 to
9c26542
Compare
sergerad
marked this pull request as ready for review
August 31, 2026 02:32
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:50
9c26542 to
e1078a4
Compare
The admin listing returned every stored record in one response, which
breaks on any non-trivial history. Replace it with a paginated listing
of committed transactions in committed order (block number, then index
within the block), served at /admin/v1/transactions. Pages hold whole
blocks; block_from doubles as the cursor and responses carry the
PaginationInfo shape the node's sync RPCs already use. Items are
metadata-only unless include_records is set. Adds
GET /admin/v1/transactions/{tx_id} to fetch one full record by id.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sergerad
force-pushed
the
sergerad-validator-admin-list
branch
from
August 31, 2026 02:59
e1078a4 to
2d57892
Compare
sergerad
requested review from
Keinberger,
Mirko-von-Leipzig and
kkovaacs
and removed request for
Keinberger
August 31, 2026 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of a 4-PR stack formalizing the validator admin API (#2455).
The admin listing returned every stored record in one response, which OOMs/breaks on any non-trivial history. Replace it with a paginated listing of committed transactions in committed order, and version the admin paths under
/admin/v1/.GET /admin/v1/transactions?block_from=&block_to=&limit=&include_records=: rows ordered by(block_num, block_tx_index)— the only order with any bearing on the chain. In-flight / never-committed rows are not listed (they remain reachable by id).PaginationInfoconvention of the node'ssync_*RPCs: responses carry{ chain_tip, block_num }, and the next page is the same request withblock_from = block_num + 1. No opaque cursor.limitis a row-count target and the block that crosses it is served in full, so a page always ends on a block boundary.include_records=true, which carries the full sealed record under a lowerlimitcap — the full-record-per-row response was most of the memory problem.GET /admin/v1/transactions/{tx_id}returns one full record by id, including for uncommitted transactions.The listing query costs one indexed seek per page (
O(log n),O(n)per sweep). The SQL comment documents why the resume point must be folded into the range's lower bound rather than passed as a second predicate: the two forms plan identically underEXPLAIN QUERY PLANbut the latter measured two orders of magnitude slower.Stack: #2531 → #2532 → #2533 → #2517
Changelog