chore: bump protocol to rc.7 + fix genesis faucet - #2538
chore: bump protocol to rc.7 + fix genesis faucet#2538SantiagoPittella wants to merge 2 commits into
Conversation
0d7a8fb to
3cde7af
Compare
| let fee_policy = BasicConstantFeePolicy::new().with_fees([ | ||
| (MintNote::script_root(), AssetAmount::ZERO), | ||
| (BurnNote::script_root(), AssetAmount::ZERO), | ||
| ]); |
There was a problem hiding this comment.
We could also add an assertion for making sure the network account policy covers the sponsorship note as well. This should be included in the auth component by default but if for some reason it's not, then the faucet will not work. It's also not explicit because it's hidden within the constructors we used so it will help as documentation of sorts.
|
Would've been nice to also implement the changes related to 0xMiden/protocol#3746, but it looks like the changes will not be in this version because there is a specific release branch and the PR was merged to |
If we want to, I can open an issue in the protocol with those changes. Though don't know when and if it will be released soon. |
3 participants
Summary
Bumps the protocol dependencies to rc.7 + updates the genesis to use the new
create_native_fungible_faucet_for_genesisfunction for faucet creation.It is not mergeable until the protocol publishing works fully with all its crates.
Changelog