Fix PHP integration dependency installation - #327
Open
somethingwithproof wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitHub Actions integration-test workflow to avoid installing an Ubuntu-version-specific Apache PHP module package that is no longer available on ubuntu-latest. The workflow already provisions PHP via shivammathur/setup-php and runs Cacti installation and operations via CLI, so removing the Apache module prevents matrix jobs from failing during dependency installation.
Changes:
- Removed
libapache2-mod-php${{ matrix.php }}from the apt-get system dependencies list. - Kept the remaining system packages (apache2, snmp tooling, rrdtool, fping) unchanged.
Three defects, all failing open or failing at setup:
- the plugin syntax check redirected find's own output rather than php's, so
PHP errors never reached the grep testing for them; the step could not fail
- MYSQL_AUTH_USR carried a literal tilde, because parameter expansion happens
after tilde expansion, so MySQL was handed a path it could not resolve
- the Cacti checkout took the default branch, which is 1.3 in development and
whose CLI installer currently fatals with an undefined __()
plugin_syslog additionally installed libapache2-mod-php${{ matrix.php }},
which Ubuntu does not package, so apt exited 100 before Cacti was reached.
Verified with actionlint, which is clean on the result.
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the Ubuntu-versioned Apache PHP module from the integration-test dependencies. PHP is provided by
shivammathur/setup-php, and the workflow executes Cacti through the CLI.Ubuntu latest no longer supplies
libapache2-mod-php8.1orlibapache2-mod-php8.2, which caused the corresponding matrix jobs to fail before tests ran.Validation
git diff --check