Fix broken demo video on SEO pages: use the homepage hero embed - #2124
Merged
Conversation
/videos/cap-demo.mp4 and its thumbnail were referenced by 13 SEO pages but never existed in public/, so every See Cap in Action section rendered a broken player. Swap each video block to the same rend.so embed the homepage hero modal uses, via the iframe shape SeoPageTemplate already supports. Autoplay params are omitted since these embeds render inline rather than in a click-opened modal.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
278
to
+281
| video: { | ||
| url: "/videos/cap-demo.mp4", | ||
| thumbnail: "/videos/cap-demo-thumbnail.png", | ||
| alt: "Cap async video code review demo showing screen recording of a pull request walkthrough with timestamped comments", | ||
| iframe: { | ||
| src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd", | ||
| title: "Cap async video code review demo showing screen recording of a pull request walkthrough with timestamped comments", |
Contributor
There was a problem hiding this comment.
These pages now select SeoPageTemplate’s iframe branch, which does not delegate picture-in-picture permission even though the canonical homepage player does. As a result, the newly embedded demos lose picture-in-picture support across all 13 migrated SEO pages.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/components/pages/seo/AsyncVideoCodeReviewsPage.tsx
Line: 278-281
Comment:
**Iframe omits picture-in-picture permission**
These pages now select `SeoPageTemplate`’s iframe branch, which does not delegate picture-in-picture permission even though the canonical homepage player does. As a result, the newly embedded demos lose picture-in-picture support across all 13 migrated SEO pages.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "See Cap in Action" sections on 13 SEO pages pointed at /videos/cap-demo.mp4 and /videos/cap-demo-thumbnail.png, but public/videos/ does not exist, so every one of them rendered a broken player.
This swaps each page's video block to the same rend.so embed the homepage hero modal uses (embed 10512af0-b922-4efa-8974-f8f14fc1886a with the brand accent), via the iframe shape SeoPageTemplate already supports. The modal-only autoplay/mute params are omitted since these embeds render inline.
Pages fixed: async-video-code-reviews, best-screen-recorder, developer-documentation-videos, hipaa-compliant-screen-recording, how-to-screen-record, mac-screen-recording-with-audio, obs-alternative, open-source-screen-recorder, record-screen, screen-recorder, screen-recording, self-hosted-screen-recording, video-recording-software.
Greptile Summary
The PR replaces broken local demo-video references on 13 public SEO landing pages with the rend.so embed already used by the homepage.
url/thumbnail/altmetadata to the supportediframe.src/iframe.titleshape.Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking iframe-permission omission that limits picture-in-picture on the new embeds.
The iframe data shape is supported, the same embed is already used by the homepage, and no blocking rendering or build failure remains; only the template branch’s missing picture-in-picture delegation affects the migrated pages.
Files Needing Attention: apps/web/components/pages/seo/AsyncVideoCodeReviewsPage.tsx and the other 12 migrated SEO page definitions
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Fix broken demo video on SEO pages: use ..." | Re-trigger Greptile
Context used: