Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/AsyncVideoCodeReviewsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,10 @@ export const asyncVideoCodeReviewsContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap async video code review demo showing screen recording of a pull request walkthrough with timestamped comments",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap async video code review demo showing screen recording of a pull request walkthrough with timestamped comments",
Comment on lines 278 to +281

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Iframe omits picture-in-picture permission

These pages now select SeoPageTemplate’s iframe branch, which does not delegate picture-in-picture permission even though the canonical homepage player does. As a result, the newly embedded demos lose picture-in-picture support across all 13 migrated SEO pages.

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/components/pages/seo/AsyncVideoCodeReviewsPage.tsx
Line: 278-281

Comment:
**Iframe omits picture-in-picture permission**

These pages now select `SeoPageTemplate`’s iframe branch, which does not delegate picture-in-picture permission even though the canonical homepage player does. As a result, the newly embedded demos lose picture-in-picture support across all 13 migrated SEO pages.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/BestScreenRecorderPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,10 @@ export const bestScreenRecorderContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap screen recorder demo showing 4K capture, webcam overlay, and instant sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap screen recorder demo showing 4K capture, webcam overlay, and instant sharing",
},
},

cta: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,10 @@ export const developerDocumentationVideosContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap developer documentation video demo showing screen recording of an API walkthrough with narration and instant share link",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap developer documentation video demo showing screen recording of an API walkthrough with narration and instant share link",
},
},

cta: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,10 @@ export const hipaaCompliantScreenRecordingContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap HIPAA-compliant screen recording demo showing self-hosted storage configuration and secure sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap HIPAA-compliant screen recording demo showing self-hosted storage configuration and secure sharing",
},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/HowToScreenRecordPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,10 @@ export const howToScreenRecordContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "How to screen record with Cap on Mac and Windows",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "How to screen record with Cap on Mac and Windows",
},
},

cta: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,10 @@ export const macScreenRecordingWithAudioContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap recording Mac screen with system audio and microphone simultaneously",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap recording Mac screen with system audio and microphone simultaneously",
},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/ObsAlternativePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,10 @@ export const obsAlternativeContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap OBS alternative demo showing instant recording and sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap OBS alternative demo showing instant recording and sharing",
},
},

cta: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,10 @@ export const openSourceScreenRecorderContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap open source screen recorder demo showing recording, sharing, and self-hosting",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap open source screen recorder demo showing recording, sharing, and self-hosting",
},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/RecordScreenPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,10 @@ export const recordScreenContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap screen recording demo showing one-click capture, webcam overlay, and instant sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap screen recording demo showing one-click capture, webcam overlay, and instant sharing",
},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/ScreenRecorderPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ export const screenRecorderContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap screen recorder demo showing high-quality and user-friendly features",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap screen recorder demo showing high-quality and user-friendly features",
},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/ScreenRecordingPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,10 @@ export const screenRecordingContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap screen recording demo showing HD capture, webcam overlay, and instant sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap screen recording demo showing HD capture, webcam overlay, and instant sharing",
},
},

cta: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,10 @@ export const selfHostedScreenRecordingContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap self-hosted screen recording demo showing S3 storage configuration and instant sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap self-hosted screen recording demo showing S3 storage configuration and instant sharing",
},
},

cta: {
Expand Down
7 changes: 4 additions & 3 deletions apps/web/components/pages/seo/VideoRecordingSoftwarePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,10 @@ export const videoRecordingSoftwareContent: SeoPageContent = {
],

video: {
url: "/videos/cap-demo.mp4",
thumbnail: "/videos/cap-demo-thumbnail.png",
alt: "Cap video recording software demo showing HD screen capture, webcam overlay, and instant sharing",
iframe: {
src: "https://www.rend.so/embed/10512af0-b922-4efa-8974-f8f14fc1886a?accent=3e63dd",
title: "Cap video recording software demo showing HD screen capture, webcam overlay, and instant sharing",
},
},

cta: {
Expand Down
Loading