Run the test suite on pull requests - #11
Merged
Merged
Conversation
Six lines pointing at the reusable runner in fog-workflows, which is where a pull_request trigger cannot live: it only fires from the repository the PR is opened against. Until now the plugin tests ran only when a maintainer remembered to, and they are the only automated check on code that decides who becomes an administrator of a FOG server -- the OIDC provider rules, the flow's state and nonce handling, and the permissions on the group association tabs. Requires FOGProject/fog-workflows#16 on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR
mastacontrola
added a commit
that referenced
this pull request
Aug 17, 2026
The workflow directory added in #11 is tracked, and the release asset is a git archive of the tag, so without an export-ignore it unpacks into the web root as lib/plugins/.github/workflows/tests.yml. That is the same reason README.md, LICENSE and tests/ are already excluded: the installer untars this straight into a directory the web server serves. Claude-Session: https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six lines pointing at
fog-plugins-tests.yml, the reusable runner merged in FOGProject/fog-workflows#16. Thepull_requesttrigger cannot live there — it only fires from the repository the PR is opened against — so the stub has to be here, and everything that might change lives in the runner.Until now the plugin tests ran only when a maintainer remembered to, and they are the only automated check on code that decides who becomes an administrator of a FOG server: the OIDC provider rules, the flow's state and nonce handling, and the permissions on the group association tabs.
Matrix is PHP 7.4 and 8.3 — 7.4 because that is the FOG floor a plugin has to keep working on, and PHP-8-only syntax lints clean before dying as a bodyless 500 inside somebody else's page.
This PR is its own first test.
🤖 Generated with Claude Code
https://claude.ai/code/session_017aBSWrDArXHTpKWkkN27LR