fix(enroll): renewal product code, AutoApprove UI text, config log visibility - #28
Merged
spbsoluble merged 1 commit intoAug 13, 2026
Conversation
…ve UI text, log config presence Three independent fixes found during UCSD triage (issues #25, #26, #27): - RenewCertificateAsync built every renewal order from the connector's DefaultProductCode alone, ignoring the template's own ProductCode/ProfileId entirely. Threaded the template's code through RenewCertificateRequest.ProfileId, falling back to DefaultProductCode only when the template doesn't have one (using a blank-check, not ??, since EnrollmentParams.ProductCode never returns null — the same dead-fallback bug that made DefaultProductCode a no-op for new enrollments). - AutoApprove's UI text claimed the plugin attempts automatic approval of pending certificates; no such call exists anywhere in the code. Corrected to say so plainly. - OrganizationNumber, DefaultProductCode, and GroupNumber had zero log visibility, which is what made a stuck-pending-orders question undiagnosable from a support log. Added presence flags to the plugin-initialized log line.
spbsoluble
merged commit Aug 13, 2026
a890a7d
into
hotfix/v1.0.1-sectigo-parity-pickup
39 checks passed
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent fixes found while triaging a UCSD support escalation and doing a docsource freshness pass — filed as issues #25, #26, #27, deliberately left un-triaged at the time, now fixed:
RenewCertificateAsyncbuilt every renewal from the connector'sDefaultProductCodealone, ignoring the template's own product code entirely. Renewals now use the template's code (threaded viaRenewCertificateRequest.ProfileId), falling back toDefaultProductCodeonly when the template doesn't have one.AutoApprove's UI text claimed the plugin attempts automatic approval of pending certificates; no such call exists anywhere in the code. Corrected the UI text.OrganizationNumber,DefaultProductCode,GroupNumberhad zero log visibility, which is what made a stuck-pending-orders question undiagnosable from a support log. Added presence flags to the plugin-initialized log line.Test plan
dotnet test CERTInext.Tests/CERTInext.Tests.csproj -c Release— 205/205 passing (5 new tests covering the renewal product-code fix; the AutoApprove and logging fixes have no feasible test seam — noted in the issues).dotnet build CERTInext/CERTInext.csproj -c Release— 0 warnings, 0 errors.