fix: track LoopStructural version in pyproject.toml instead of version.py - #312
Merged
Conversation
…n.py Removes the dynamic version.py indirection in favor of a static [project].version field in pyproject.toml, with __version__ now read via importlib.metadata at runtime. release-please's LoopStructural component previously tracked path "LoopStructural", a subdirectory it could never actually update pyproject.toml/setup.py from (they live at repo root) -- it only ever bumped the now-removed version.py via a filename search. The component path is repointed to "." so release-please can update pyproject.toml directly, and the changelog (previously split between the stale root CHANGELOG.md and the actually-maintained LoopStructural/CHANGELOG.md) is merged into the root file, which is now the single source of truth. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lachlangrose
force-pushed
the
fixing-version-ci
branch
from
August 14, 2026 06:37
e58ed7c to
b90babb
Compare
4 tasks
lachlangrose
added a commit
that referenced
this pull request
Aug 14, 2026
Not imported anywhere -- loop_interpolation's real version already lives statically in its own pyproject.toml. Left over from before that package had its own static version, it's also collateral damage from repointing the LoopStructural component's path to "." (#312): release-please's generic version.py filename search, previously scoped to the old LoopStructural/ subdirectory, now scans the whole repo and was pulling this unrelated file into LoopStructural's release PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoopStructural/version.py;[project].versioninpyproject.tomlis now the single source of truth, and__version__is read at runtime viaimportlib.metadata.LoopStructuralcomponent's tracked path wasLoopStructural(a subdirectory), so release-please could never actually reach the realpyproject.toml/setup.pyat repo root — it only ever bumpedversion.pyvia a filename search. The component path is now., with an explicitcomponent: "LoopStructural"so the existingLoopStructural--release_createdworkflow output still resolves.LoopStructural/CHANGELOG.md(the one release-please was actually maintaining) into the rootCHANGELOG.md, which had gone stale since 1.6.4. RootCHANGELOG.mdis now the single changelog release-please will update going forward.Test plan
python -c "import LoopStructural; print(LoopStructural.__version__)"prints1.7.0pyproject.tomlparses and[project].versionreads1.7.0masterproduces a PR that bumpspyproject.toml's version and appends to rootCHANGELOG.md🤖 Generated with Claude Code