Fix OpenAI API request option handling - #2295
Open
patrick-andstar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_lengthrequest option to the underlying chat generation call.stopas either a string or a list of strings, and normalize a scalar before applying the existing leading-newline workaround.Motivation
max_lengthwas accepted by the request model but silently ignored. In addition, clients using the standard scalar form ofstopreceived a validation error even though this script exposes an OpenAI-compatible chat-completions endpoint.Compatibility
Existing list-valued
stopinput keeps its current behavior. No model loading, streaming protocol, or authentication behavior changes.Testing
stop, existing liststop, and forwardingmax_lengthtomodel.chat.openai_api.py.git diff --check.Duplicate Work Check
Searched open Issues and PRs for
openai_api,max_length, andstop words; no matching open change was found. Historical PR #1038 added streaming stop-word support but does not cover these request options. Open PR #2255 changes the unrelated plugin-evaluation parser.