Skip to content

Fix OpenAI API request option handling #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrick-andstar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix OpenAI API request option handling #2295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion openai_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class ChatCompletionRequest(BaseModel):
top_k: Optional[int] = None
max_length: Optional[int] = None
stream: Optional[bool] = False
stop: Optional[List[str]] = None
stop: Optional[Union[str, List[str]]] = None


class ChatCompletionResponseChoice(BaseModel):
Expand Down Expand Up @@ -143,6 +143,8 @@ async def list_models():

# To work around that unpleasant leading-\n tokenization issue!
def add_extra_stop_words(stop_words):
if isinstance(stop_words, str):
stop_words = [stop_words]
if stop_words:
_stop_words = []
_stop_words.extend(stop_words)
Expand Down Expand Up @@ -397,6 +399,8 @@ async def create_chat_completion(request: ChatCompletionRequest):
gen_kwargs['temperature'] = request.temperature
if request.top_p is not None:
gen_kwargs['top_p'] = request.top_p
if request.max_length is not None:
gen_kwargs['max_length'] = request.max_length

stop_words = add_extra_stop_words(request.stop)
if request.functions:
Expand Down