Type the hyphen into the TUI date picker instead of stepping the date - #365
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the HEY SDK dependency to surface specific 422 draft validation errors.
Changes:
- Redirects the SDK dependency to a fork containing draft error parsing.
- Currently introduces an invalid
go.moddirective and lacks regression coverage.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Suppressed comments (1)
go.mod:13
- The dependency change alters user-visible draft edit/send failures, but no command-level regression test serves a JSON 422 and asserts that its
errorstext reaches the CLI. Add cases for bothUpdateDraftandSendDraftto the existing draft lifecycle tests so a future SDK update cannot silently restore the generic message.
replace github.com/basecamp/hey-sdk/go => github.com/AruneshDwivedi/hey-sdk/go 7f51159f3c83
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1aa7065 to
9c91ad1
Compare
1c2f677 to
adcccc2
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
adcccc2 to
f5cec6f
Compare
jeremy
changed the title
|
Rebased onto main and pushed f5cec6f on top: Retitled and rewrote the description to match what the branch now contains — the force-push on Sep 2 replaced the SDK-pin change with this fix, and the go.mod thread is outdated as a result. The draft 422 half is hey-sdk#133; once that ships, the CLI picks it up through the routine hey-sdk bump with no code change here.
|
The "-" key typed in the date field is now swallowed instead of stepping the date backward or being inserted as a literal character. This fixes basecamp#368 where users could not enter the YYYY-MM-DD delimiter.
The bug in hey-cli#368 is that a date cannot be typed: "-" was bound as the step-back key, so the separator moved the date instead of landing in the field. Swallowing the key stops the step but still leaves the field without its separator, and it took the down arrow's step with it. "-" now goes through to the input like any other character, and the arrows keep stepping the day both ways as the help says they do.
f5cec6f to
6428010
Compare
Fixes #368.
-was bound as the date field's step-back key, so typing the separator of a YYYY-MM-DD date moved the date a day instead of landing in the field.-now goes through to the input like any other character; the arrows keep stepping the day both ways, and+/=still step forward since neither can appear in a date.This branch originally carried a go.mod pin for the draft 422 fix. That half lives in hey-sdk#133 — the wrappers there are what surface HEY's reasons — and the CLI needs no code change for it beyond the routine hey-sdk bump once that ships.