Fix release tags pointing at the wrong commit - #35
Merged
Conversation
softprops/action-gh-release defaults target_commitish to the repo's default branch when unset, not to the branch that triggered the run — so the version-bump and README-sync commits pushed by earlier steps in this same job were silently excluded from the tagged release. Both v0.1.9 and v0.1.9-staging ended up pointing at the same stale commit instead of their respective branch's actual tip. Set target_commitish to github.ref_name so the release tag always lands on this branch's current tip, matching the floating main/staging alias tag. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
softprops/action-gh-releasedefaultstarget_commitishto the repo's default branch when unset, not to the branch that triggered the run — so the version-bump and README-sync commits pushed earlier in the same job were silently excluded from the tagged release. Bothv0.1.9andv0.1.9-stagingended up pointing at the same stale commit instead of their respective branch's actual tip.target_commitish: ${{ github.ref_name }}so the release tag always lands on the branch's current tip, matching the floatingmain/stagingalias tag.Test plan
vX.Y.Z-stagingtag and thestagingalias tag point at the same commit (fixes the mismatch found ongit+https://github.com/eeadata/EEALakeHouse.python.git@staging)🤖 Generated with Claude Code