Skip to content

Fix release tags pointing at the wrong commit #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oskaresparza merged 1 commit into from
Aug 14, 2026
+7 −0
Merged

Fix release tags pointing at the wrong commit #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,18 @@ jobs:
fi
done

# target_commitish is required here: without it, the GitHub API creates
# a brand-new tag from the *repository's default branch* tip, not from
# github.sha (the commit that triggered this run) and not from the
# version-bump/README commits the earlier steps just pushed to this
# branch. Pointing it at github.ref_name makes the release tag land on
# this branch's actual current tip.
- name: Create GitHub release
uses: softprops/action-gh-release@v3
with:
tag_name: v${{ steps.version.outputs.version }}${{ github.ref_name == 'staging' && '-staging' || '' }}
name: v${{ steps.version.outputs.version }} (${{ github.ref_name }})
target_commitish: ${{ github.ref_name }}
files: dist/*
generate_release_notes: true
prerelease: ${{ github.ref_name == 'staging' }}
Expand Down