Skip to content

chore!: [GeminiDataAnalytics] remove obsolete ContextRetrievalService files - #9555

Merged
bshaffer merged 3 commits into
mainfrom
feat/geminidataanalytics
Aug 26, 2026
Merged

chore!: [GeminiDataAnalytics] remove obsolete ContextRetrievalService files#9555
bshaffer merged 3 commits into
mainfrom
feat/geminidataanalytics

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete structural files for GeminiDataAnalytics that are no longer generated.

Testing Deletions

I attempted to load the deleted classes to prove they do not exist anymore.

Test Script:

<?php
require 'vendor/autoload.php';
echo "Testing deleted classes...\n";
if (class_exists('Google\\Cloud\\GeminiDataAnalytics\\V1beta\\Client\\ContextRetrievalServiceClient')) {
    echo "ERROR: ContextRetrievalServiceClient still exists!\n";
    exit(1);
} else {
    echo "SUCCESS: ContextRetrievalServiceClient does not exist.\n";
}

Output:

Testing deleted classes...
SUCCESS: ContextRetrievalServiceClient does not exist.

BREAKING_CHANGE_REASON=In googleapis commit 7c4d9e72e0 (feat: Initial commit for GeminiDataAnalytics API service), the ContextRetrievalService and its related messages were explicitly removed from the v1beta proto surface. This was synced to google-cloud-php in PR #8533. OwlBot synced these changes but failed to delete the corresponding orphaned files in google-cloud-php. Librarian correctly removes these obsolete artifacts.

For googleapis/librarian#7366

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 21:53
@snippet-bot

snippet-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sofisl
sofisl force-pushed the feat/geminidataanalytics branch from 9e03053 to 0611251 Compare August 21, 2026 23:34
@bshaffer bshaffer changed the title chore(GeminiDataAnalytics): remove obsolete ContextRetrievalService files chore!: [GeminiDataAnalytics] remove obsolete ContextRetrievalService files Aug 25, 2026

@bshaffer bshaffer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These other class removals are considered breaking, but GeminiDataAnalytics is at version 0.12.0 (pre-GA), we do not need to release a new major version to make these chagnes.

Please remove (or move to a different PR) the phpstan changes and we can merge this.

Comment thread phpstan.neon.dist Outdated
reportUnmatchedIgnoredErrors: false

ignoreErrors:
- identifier: unset.possiblyHookedProperty

@bshaffer bshaffer Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changes part of a GeminiDataAnalytics PR? They do not seem related to the other changes in this PR, and the PHPStan check has passed in other PRs

If PHPstan needs to be fixed, it should be split into a separate PR.

@sofisl

sofisl commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

I have reverted the PHPStan changes from this PR, removed them from the PR body description, and opened a new PR for them here: #9581. This PR should be good to go as soon as #9581 merges (or whenever the PHPStan CI check here turns green!).

@sofisl
sofisl requested a review from bshaffer August 25, 2026 21:53
@bshaffer
bshaffer merged commit 0071379 into main Aug 26, 2026
40 checks passed
@bshaffer
bshaffer deleted the feat/geminidataanalytics branch August 26, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants