chore!: [GeminiDataAnalytics] remove obsolete ContextRetrievalService files - #9555
Conversation
|
Here is the summary of changes. You are about to delete 8 region tags.
This comment is generated by snippet-bot.
|
9e03053 to
0611251
Compare
bshaffer
left a comment
There was a problem hiding this comment.
These other class removals are considered breaking, but GeminiDataAnalytics is at version 0.12.0 (pre-GA), we do not need to release a new major version to make these chagnes.
Please remove (or move to a different PR) the phpstan changes and we can merge this.
| reportUnmatchedIgnoredErrors: false | ||
|
|
||
| ignoreErrors: | ||
| - identifier: unset.possiblyHookedProperty |
There was a problem hiding this comment.
Why are these changes part of a GeminiDataAnalytics PR? They do not seem related to the other changes in this PR, and the PHPStan check has passed in other PRs
If PHPstan needs to be fixed, it should be split into a separate PR.
This PR removes obsolete structural files for GeminiDataAnalytics that are no longer generated.
Testing Deletions
I attempted to load the deleted classes to prove they do not exist anymore.
Test Script:
Output:
BREAKING_CHANGE_REASON=In googleapis commit 7c4d9e72e0 (feat: Initial commit for GeminiDataAnalytics API service), the
ContextRetrievalServiceand its related messages were explicitly removed from thev1betaproto surface. This was synced togoogle-cloud-phpin PR #8533. OwlBot synced these changes but failed to delete the corresponding orphaned files ingoogle-cloud-php. Librarian correctly removes these obsolete artifacts.For googleapis/librarian#7366