chore: fix PHPStan failures for PHP 8.4 and unmatched ignores - #9581
Open
sofisl wants to merge 1 commit into
Open
chore: fix PHPStan failures for PHP 8.4 and unmatched ignores#9581sofisl wants to merge 1 commit into
sofisl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes recent PHPStan CI failures related to PHP 8.4 property hooks and unmatched ignores.
The gapic-generator-php has started generating
protectedproperties, which causes PHPStan to fail withunset.possiblyHookedPropertysince PHP 8.4 added property hooks. Also, as obsolete files are being cleaned up across the repository, thearray.duplicateKeyignore rule is occasionally left unmatched, causing the CI to fail.We can fix this by:
unset.possiblyHookedPropertytophpstan.neon.distignoreErrors.reportUnmatchedIgnoredErrors: falsetophpstan.neon.dist.This was originally included in #9555 but split into a separate PR to keep changes isolated.