[raft/rid] Raftstore skeleton - #1623
Merged
Merged
Conversation
This was referenced Aug 11, 2026
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
from
August 11, 2026 12:24
288ff9f to
3f032d6
Compare
MariemBaccari
marked this pull request as draft
August 11, 2026 12:29
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
from
August 11, 2026 12:38
3f032d6 to
5bd4817
Compare
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
2 times, most recently
from
August 11, 2026 13:25
d0cfae5 to
9b8bbc9
Compare
MariemBaccari
marked this pull request as ready for review
August 11, 2026 13:27
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
5 times, most recently
from
August 19, 2026 09:49
8b63792 to
3689584
Compare
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
2 times, most recently
from
August 19, 2026 12:12
942193d to
661d76e
Compare
This was referenced Aug 19, 2026
mickmis
approved these changes
Aug 19, 2026
| switch proposal.RequestType { | ||
|
|
||
| default: | ||
| handler, ok := actions.Registry[string(proposal.RequestType)] |
Contributor
There was a problem hiding this comment.
Update registry map key type to use RequestType
Contributor
Author
There was a problem hiding this comment.
Since the registry is defined outside of both raftstore and sqlstore and is used by both, it feels odd leaking consensus.RequestType into it. What do you think ?
Contributor
There was a problem hiding this comment.
Yes indeed. That actually raises the question of whether there is (and will always be) a 1-1 mapping between DSS operations and raft messages? But it looks like those are different although overlapping sets. So LGTM.
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
from
August 19, 2026 14:02
661d76e to
7c458e1
Compare
barroco
added
the
dss-raft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rid Raftstore skeleton