Skip to content

[raft/scd] Extract delete subscription - #1643

Merged
mickmis merged 1 commit into
interuss:masterfrom
Orbitalize:scd_subscriptions_extract
Aug 31, 2026
Merged

[raft/scd] Extract delete subscription#1643
mickmis merged 1 commit into
interuss:masterfrom
Orbitalize:scd_subscriptions_extract

Conversation

@MariemBaccari

@MariemBaccari MariemBaccari commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Chained PR: #1627 -> #1642 -> #1643 -> #1644 -> #1645 -> #1646 -> #1649 -> #1650 -> #1651 -> #1653 -> #1654 -> #1656 -> #1657 -> #1655 -> #1666 -> #1667 -> #1668 -> #1669

Extract delete subscription business logic in scd.

@MariemBaccari
MariemBaccari force-pushed the scd_subscriptions_extract branch from 134cf6c to ebcf4fa Compare August 19, 2026 12:13
@MariemBaccari
MariemBaccari force-pushed the scd_subscriptions_extract branch from ebcf4fa to 85ff58c Compare August 19, 2026 12:17
@MariemBaccari
MariemBaccari marked this pull request as ready for review August 19, 2026 12:30
@MariemBaccari
MariemBaccari force-pushed the scd_subscriptions_extract branch from 85ff58c to f193627 Compare August 19, 2026 14:18
@barroco barroco added the dss-raft Relating to the application-layer consensus implemenation based on raft label Aug 20, 2026

@mickmis mickmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(f193627) LGTM

Comment thread pkg/scd/actions/subscription.go
Comment thread pkg/scd/actions/subscription.go
@MariemBaccari
MariemBaccari force-pushed the scd_subscriptions_extract branch from d0b5c4c to ad3d4bc Compare August 31, 2026 11:52
@mickmis
mickmis merged commit 634a173 into interuss:master Aug 31, 2026
17 of 18 checks passed
@mickmis
mickmis deleted the scd_subscriptions_extract branch August 31, 2026 11:58
@mickmis

mickmis commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Note: ignored flaky CI run (see #1660)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dss-raft Relating to the application-layer consensus implemenation based on raft

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants