Skip to content

Fix 12844 notification external link - #12845

Merged
SchrodingersGat merged 7 commits into
inventree:masterfrom
Leopoldius:fix-12844-notification-external-link
Sep 13, 2026
Merged

SchrodingersGat merged 7 commits into
inventree:masterfrom
Leopoldius:fix-12844-notification-external-link

Conversation

@Leopoldius

Copy link
Copy Markdown
Contributor

Summary

  • preserve absolute external notification URLs
  • prefix internal notification links with the frontend base path only when required
  • avoid double-prefixing links which already contain the frontend base path
  • add Playwright regression coverage for external, relative internal, and already-prefixed internal links

Fixes #12844

Testing

The issue was reproduced against the official inventree/inventree:1.5.4 image and traced through the database, serializer and production frontend bundle.

Added Playwright regression coverage for:

  • https://example.com/path -> unchanged
  • /settings/admin/ -> /web/settings/admin/
  • /web/settings/admin/ -> unchanged

@netlify

netlify Bot commented Sep 12, 2026

Copy link
Copy Markdown

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit e975881
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6aa68ae3a9499f00080e84ed

@matmair matmair added the bug Identifies a bug which needs to be addressed label Sep 12, 2026
@matmair matmair added this to the 1.5.5 milestone Sep 12, 2026
@matmair matmair added backport Apply this label to a PR to enable auto-backport action User Interface Related to the frontend / User Interface backport-to-1.5.x labels Sep 12, 2026
@SchrodingersGat

Copy link
Copy Markdown
Member

@Leopoldius thanks for the fix!

@SchrodingersGat
SchrodingersGat enabled auto-merge (squash) September 13, 2026 11:37
@SchrodingersGat
SchrodingersGat merged commit 13cc625 into inventree:master Sep 13, 2026
32 of 33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
1.5.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@Leopoldius
Leopoldius deleted the fix-12844-notification-external-link branch September 13, 2026 12:30
SchrodingersGat added a commit that referenced this pull request Sep 13, 2026
* Fix external notification links

* Add notification link regression test

* Preserve fallback for empty notification links

* Satisfy Biome optional-chain check

* Apply Biome formatting

* Retrigger CI

---------


(cherry picked from commit 13cc625)

Co-authored-by: Leonid Zaliubovskyi <Leopoldius@users.noreply.github.com>
Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Apply this label to a PR to enable auto-backport action backport-to-1.5.x bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External notification links are incorrectly prefixed with the frontend base URL

3 participants