Skip to content

[1.5.x] Fix 12844 notification external link (#12845) - #12847

Merged
SchrodingersGat merged 1 commit into
1.5.xfrom
backport/1.5.x/pr-12845
Sep 13, 2026
Merged

[1.5.x] Fix 12844 notification external link (#12845)#12847
SchrodingersGat merged 1 commit into
1.5.xfrom
backport/1.5.x/pr-12845

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from master to 1.5.x:

Questions ?

Please refer to the Backport tool documentation

@Leopoldius @SchrodingersGat
Fix 12844 notification external link (#12845)
7ed3afd 
* Fix external notification links

* Add notification link regression test

* Preserve fallback for empty notification links

* Satisfy Biome optional-chain check

* Apply Biome formatting

* Retrigger CI

---------

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
(cherry picked from commit 13cc625)
@github-actions github-actions Bot mentioned this pull request Sep 13, 2026
Merged
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface labels Sep 13, 2026
@SchrodingersGat SchrodingersGat added this to the 1.5.5 milestone Sep 13, 2026
@flakiness-io

flakiness-io Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
7ed3afd ✅ Passed 335 passed · 9 flaky 6 runs
⚠️ 9 flaky

⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pui_login.spec.ts:146 › Login - Cold vs Warm vs Hot Load
⚠️ Ubuntu 24.04 · chromium src/frontend/tests/pui_login.spec.ts:146 › Login - Cold vs Warm vs Hot Load
⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pui_login.spec.ts:282 › Login - Network Errors & Retry
⚠️ Ubuntu 24.04 · chromium src/frontend/tests/pui_machines.spec.ts:21 › Machines - Activation
⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pui_machines.spec.ts:21 › Machines - Activation
⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pui_notifications.spec.ts:58 › Notifications - link targets
⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pages/pui_part.spec.ts:476 › Parts - Details
⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pui_printing.spec.ts:137 › Printing - Report Editing
⚠️ Ubuntu 24.04 · firefox src/frontend/tests/pages/pui_transfer.spec.ts:105 › Transfer Order - Calendar

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

@SchrodingersGat
SchrodingersGat merged commit 063e066 into 1.5.x Sep 13, 2026
31 checks passed
@SchrodingersGat
SchrodingersGat deleted the backport/1.5.x/pr-12845 branch September 13, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SchrodingersGat SchrodingersGat Awaiting requested review from SchrodingersGat SchrodingersGat is a code owner

Assignees

No one assigned

Labels

bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface

Projects

None yet

Milestone

1.5.5

Development

Successfully merging this pull request may close these issues.

2 participants

@SchrodingersGat @Leopoldius