test: clarify routed stream cancellation coverage - #164
Merged
Conversation
Contributor
|
Verified, and it addresses the note from #160 the right way.
One nit, take it or leave it: Worth stating for whoever reads this later: neither test exercises the GC-sensitive part of the original failure, and that is deliberate. Reproducing it needs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestInitandRequestinputsstream.controller.abort()path retains the exact signal passed to the routed telemetry requestFollow-up to #160.
Tests
./scripts/test./scripts/lintNote
Low Risk
Only test renames and new coverage in
browser-routing.test.ts; no production code paths change.Overview
Test-only follow-up to routed browser subresource behavior: no runtime changes.
Renames the abort-signal test to
preserves signal identity from RequestInit and Request inputs, keeping the same assertions that the routed VM fetch receives the exactAbortSignalfrom eitherRequestInitor aRequestobject.Adds
keeps stream.controller.abort connected to routed telemetry requests, which openskernel.browsers.telemetry.stream, checks the underlying routed fetch usesstream.controller.signal, and confirms callingstream.controller.abort()aborts that signal.Reviewed by Cursor Bugbot for commit 3f07f94. Bugbot is set up for automated code reviews on this repo. Configure here.