Skip to content

test: clarify routed stream cancellation coverage #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 2 commits into from
Aug 10, 2026
Merged

test: clarify routed stream cancellation coverage #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed7ba9
Clarify browser routing cancellation coverage
rgarcia Aug 10, 2026
3f07f94
Merge remote-tracking branch 'origin/main' into hypeship/clarify-rout…
rgarcia Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion tests/lib/browser-routing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ describe('browser routing', () => {
});
});

test('preserves the caller abort signal for routed requests', async () => {
test('preserves signal identity from RequestInit and Request inputs', async () => {
const controller = new AbortController();
const cache = new BrowserRouteCache();
cache.set({
Expand Down Expand Up @@ -224,6 +224,32 @@ describe('browser routing', () => {
expect(routedSignal === request.signal).toBe(true);
});

test('keeps stream.controller.abort connected to routed telemetry requests', async () => {
let routedSignal: AbortSignal | null | undefined;
const kernel = new Kernel({
apiKey: 'k',
baseURL: 'https://api.example/',
fetch: async (_input, init) => {
routedSignal = init?.signal;
return new Response('id: 1\ndata: {"seq":1}\n\n', {
status: 200,
headers: { 'content-type': 'text/event-stream' },
});
},
});
kernel.browserRouteCache.set({
sessionId: 'sess-1',
baseURL: 'http://browser-session.test/browser/kernel',
jwt: 'token-abc',
});

const stream = await kernel.browsers.telemetry.stream('sess-1');

expect(routedSignal).toBe(stream.controller.signal);
stream.controller.abort();
expect(routedSignal?.aborted).toBe(true);
});

test('ignores browser responses that do not include a usable jwt', async () => {
await withBrowserRoutingEnv('process', async () => {
const kernel = new Kernel({
Expand Down
Loading