Harden background compressor against stalled native work - #23
Draft
marcmy wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core.Compactorso the background watcher can tell whether work is advancing and identify the active phase/fileRoot cause
PR #1 fixed the cancellation/disposal race and idle-resume lifecycle, but the watcher still awaited
Core.Compactor.RunAsyncindefinitely.Compactorultimately performs synchronous file/native work (File.OpenHandle/WofSetFileDataLocation) that cannot be interrupted by the managed cancellation token once the call is already executing. If that operation never returns, the folder'sIsWorkingcleanup cannot run and the watcher remains stuck on that folder.Behavior after this change
Normal cancellation still follows the ordinary cooperative path. If Windows does not return from the current native operation within the grace period, CompactGUI releases the watcher/UI without disposing native state that may still be executing. The orphaned task owns its compactor until it exits, and that folder is skipped by later background runs in the meantime.
A genuinely idle background operation that reports no progress for 30 active minutes is cancelled through the same safe path. Watchdog warnings include the current phase and file to make another occurrence diagnosable.
Validation
CompactGUI.Core/Compactor.csandCompactGUI.Watcher/BackgroundCompactor.vbmasterRuntime checks