Fix manual compression resume lifecycle - #24
Draft
marcmy wants to merge 6 commits into
Draft
Conversation
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compress againfollowed byCompress Selectednow loads the saved checkpoint instead of starting with a fresh progress baselineCompress SelectedRoot cause
The resume implementation introduced in PR #7 passed
SavedCompressionSessionobjects only fromAddFoldersAsyncintoCompressFoldersAsync. A folder that stayed in the Home list after saving progress therefore had no resume session whenCompress againwas used, while the add-folder Resume path explicitly invokedCompressFoldersAsyncimmediately.The exit paths were also independent of the manual compression lifecycle: tray Exit and true window-close exits could reach
Application.Current.Shutdown()without first asking the activeCore.Compactorto stop and persist/leave its current work.Expected behavior after this change
Resume without removing the folder
Resume after re-adding
Stop / exit during manual compression
Normal window close-to-tray behavior for watched folders is unchanged because that action does not exit the app.
Scope
CompactGUI/ViewModels/HomeViewModel.vbCompactGUI/ViewModels/MainWindowViewModel.vbCompactGUI/Services/WindowService.vbValidation
Runtime checks