Skip to content

feat: bounty creation ui formatting - #32

Merged
lambdakilo merged 1 commit into
mainfrom
12/feat/bounty-creation-ui
Aug 11, 2026
Merged

feat: bounty creation ui formatting#32
lambdakilo merged 1 commit into
mainfrom
12/feat/bounty-creation-ui

Conversation

@lambdakilo

@lambdakilo lambdakilo commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

formatting for commit 4cd5 that was accidentally pushed to main directly without pr. changed ci, docs and scripts. ci are unlimited mins per month for public repos. 2000 minutes per month for private repos.

Related issue

Closes #12

Changes made

  • run author checklist, add author checklist items to ci pipeline for pr, create bun run pr for easier pr checking, update docs to match these.

Author checklist

  • Matches the spec
  • bun run format - code has been formatted
  • bun run lint - no prettier/eslint errors
  • bun run check - no svelte-check/TypeScript errors
  • bun run test - all tests pass
  • bun run build - build succeeds
  • I tested the relevant changes manually

Reviewer manual testing checklist

  • check if the commit 4cd5 actually needed formatting
  • check if the changes make sense and comment if you disagree

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates contributor-facing workflow and documentation around PR preflight checks by adding a bun run pr convenience script, documenting it, and introducing a GitHub Actions CI workflow to run the same checks on pull requests.

Changes:

  • Add bun run pr script to run format/lint/check/test/build in sequence.
  • Add CI workflow to run lint/check/test/build on every PR (and on manual dispatch), including Playwright browser install for vitest browser mode.
  • Update README and PR template to reflect the new PR preflight workflow.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
README.md Documents bun run pr and clarifies what CI runs on PRs.
package.json Adds a pr script and tweaks scripts section formatting.
.github/workflows/ci.yml Introduces PR CI pipeline for lint/check/test/build with Bun + Playwright.
.github/pull_request_template.md Improves template spacing and adds mention of bun run pr.
Suppressed comments (1)

.github/pull_request_template.md:25

  • The reviewer checklist item is blank, so it’s easy to miss what reviewers are expected to verify. A short placeholder makes the template clearer and more actionable.
## Reviewer manual testing checklist

- [ ]

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"format": "prettier --write .",
"test:unit": "vitest",
"test": "npm run test:unit -- --run"
"test": "npm run test:unit -- --run",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sveltekit scaffolding uses npm by default for tests even though project was created using bunx sv satcode. leaving it as is because of this and not using bun for that.

Comment thread .github/workflows/ci.yml
Comment on lines +19 to +22
- name: Set up Bun
uses: oven-sh/setup-bun@v2
with:
bun-version: latest

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair but i think ill rather leave this like this and let ci break and tell us automatically if a new semver change breaks our pr ci

## Changes made
-

-

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again with this nonsense you said this the last time already on another pr. bad copilot!

Comment thread README.md
Comment on lines +40 to +46
Or run them all in one go:

```sh
bun run pr
```

CI runs the same checks (all except `format`) on every pull request.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope its stated in this pr that this is just a follow up fixup pr for the commit that got into the main accidentally

@guildm4ster guildm4ster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lambdakilo
lambdakilo merged commit 95d5224 into main Aug 11, 2026
2 checks passed
@lambdakilo
lambdakilo deleted the 12/feat/bounty-creation-ui branch August 11, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create bounty creation UI

3 participants