Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
## Summary

## Related issue

Closes #

## Changes made
-

-

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again with this nonsense you said this the last time already on another pr. bad copilot!


## Author checklist

`bun run pr` runs all the commands below in one go.

- [ ] Matches the spec
- [ ] `bun run format` - code has been formatted
- [ ] `bun run lint` - no prettier/eslint errors
Expand All @@ -14,4 +21,5 @@ Closes #
- [ ] I tested the relevant changes manually

## Reviewer manual testing checklist
- [ ]

- [ ]
42 changes: 42 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: CI

on:
pull_request:
workflow_dispatch:

concurrency:
group: ci-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
checks:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- name: Check out repository
uses: actions/checkout@v5

- name: Set up Bun
uses: oven-sh/setup-bun@v2
with:
bun-version: latest
Comment on lines +19 to +22

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair but i think ill rather leave this like this and let ci break and tell us automatically if a new semver change breaks our pr ci


- name: Install dependencies
run: bun install --frozen-lockfile

# Needed by the vitest browser-mode project (chromium via playwright)
- name: Install Playwright browsers
run: bunx playwright install chromium --with-deps

# `bun run format` is local-only; CI verifies formatting via prettier --check in `lint`
- name: Lint (prettier + eslint)
run: bun run lint

- name: Check (svelte-check + TypeScript)
run: bun run check

- name: Test
run: bun run test

- name: Build
run: bun run build
10 changes: 9 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ bun run test # unit tests
bun run build # production build
```

Or run them all in one go:

```sh
bun run pr
```

CI runs the same checks (all except `format`) on every pull request.
Comment on lines +40 to +46

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope its stated in this pr that this is just a follow up fixup pr for the commit that got into the main accidentally


## License

This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or any later version.
This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or any later version.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"lint": "prettier --check . && eslint .",
"format": "prettier --write .",
"test:unit": "vitest",
"test": "npm run test:unit -- --run"
"test": "npm run test:unit -- --run",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sveltekit scaffolding uses npm by default for tests even though project was created using bunx sv satcode. leaving it as is because of this and not using bun for that.

"pr": "bun run format && bun run lint && bun run check && bun run test && bun run build"
},
"devDependencies": {
"@eslint/js": "^10.0.1",
Expand Down